build: Globally use package SonarAnalyzer.CSharp

src/Directory.Build.props

@@ -11,6 +11,11 @@
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
   </PropertyGroup>
 
+  <!-- Global Packages -->
+  <ItemGroup>
+    <PackageReference Include="SonarAnalyzer.CSharp" PrivateAssets="All" />
+  </ItemGroup>
+
   <ItemGroup>
     <Using Include="Serilog" />
   </ItemGroup>

src/Recyclarr.Cli/Recyclarr.Cli.csproj

@@ -13,10 +13,6 @@
     <PackageReference Include="Serilog.Expressions" />
     <PackageReference Include="Serilog.Sinks.Console" />
     <PackageReference Include="Serilog.Sinks.File" />
-    <PackageReference Include="SonarAnalyzer.CSharp">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
     <PackageReference Include="Spectre.Console.Analyzer" PrivateAssets="All" />
     <PackageReference Include="Spectre.Console.Cli" />
     <PackageReference Include="TestableIO.System.IO.Abstractions" />

src/Recyclarr.Common/Recyclarr.Common.csproj

@@ -6,10 +6,6 @@
     <PackageReference Include="JetBrains.Annotations" />
     <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="Serilog" />
-    <PackageReference Include="SonarAnalyzer.CSharp">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
     <PackageReference Include="Spectre.Console" />
     <PackageReference Include="System.Reactive" />
     <PackageReference Include="TestableIO.System.IO.Abstractions.Extensions" />

src/Recyclarr.Gui/Recyclarr.Gui.csproj

@@ -14,10 +14,6 @@
     <PackageReference Include="ReactiveUI.Blazor" />
     <PackageReference Include="Serilog.AspNetCore" />
     <PackageReference Include="Serilog.Sinks.File" />
-    <PackageReference Include="SonarAnalyzer.CSharp">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>

src/Recyclarr.TrashLib/Recyclarr.TrashLib.csproj

@@ -13,10 +13,6 @@
     <PackageReference Include="JetBrains.Annotations" />
     <PackageReference Include="Newtonsoft.Json.Schema" />
     <PackageReference Include="Serilog" />
-    <PackageReference Include="SonarAnalyzer.CSharp">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
     <PackageReference Include="SuperLinq" />
     <PackageReference Include="System.Data.HashFunction.FNV" />
     <PackageReference Include="System.Private.Uri" />

src/tests/Directory.Build.props

@@ -6,6 +6,10 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <!-- Packages we don't want from the root props -->
+    <PackageReference Remove="SonarAnalyzer.CSharp" />
+
+    <!-- Packages that apply to all tests -->
     <PackageReference Include="AgileObjects.ReadableExpressions" PrivateAssets="All" />
     <PackageReference Include="AutofacContrib.NSubstitute" PrivateAssets="All" />
     <PackageReference Include="AutoFixture" PrivateAssets="All" />