bebd28bc11
build: Upgrade FluentValidation
1 year ago
fc6a186809
build: Upgrade morelinq
2 years ago
93a8c8bc22
build: Upgrade all nuget packages
2 years ago
1a16432341
refactor: Remove inappropriate usage of `required` in CliSettings
2 years ago
f7bfab065d
fix: Show default value in `config list` help
2 years ago
dc93b10e64
test: Add await where necessary
2 years ago
e54cef0859
feat: `config list local` implemented
2 years ago
ce481e0d1f
refactor: Config loader no longer reuses state
2 years ago
f5386dfeda
fix: Template config listing is no longer reversed
2 years ago
f6f6ea3192
style: Solution-wide code cleanup
2 years ago
a3c172cf02
feat: Add config list templates command
...
Lists template YAML files in the trash repo.
2 years ago
902fbad4bf
chore: Remove unused run configuration
2 years ago
a934e68227
fix: Enable strict parsing to error on unknown CLI options
2 years ago
7c15c14f40
refactor: More concise usage of UsedImplicitly in SyncCommand
2 years ago
fe2b062ba7
fix: Consistently set FormatIDs to avoid incorrect logs
2 years ago
f298926353
fix: Use INF instead of DBG for score update log
2 years ago
58bbb94a44
build: Upgrade all nuget packages
2 years ago
a22d6dec33
fix: Log janitor updated to clean up logs in new 'cli' dir
2 years ago
e222f547cc
test: Fix config loader test
...
No exception is thrown when a non-empty config results in no usable
configuration.
2 years ago
c82894291f
fix: Do not fail on empty service type sections
2 years ago
bf9a08c19c
test: Fix broken unit test
2 years ago
cffb8d783a
refactor: Convert processors/updaters to pipelines
2 years ago
e3d6d4f79a
refactor: Remove DI for IServiceConfiguration in API services
2 years ago
bcc65857df
refactor: Split Sonarr/Radarr orthogonally into service-based classes
...
Instead of organizing logic using service, such as Sonarr or Radarr,
organize it using function. So now logic is broken up by Custom Format,
Release Profile, and Quality Size.
2 years ago
7dec45a07a
refactor: Eliminate generics for config type
2 years ago
289d661247
refactor: Silence warnings in _Layout.cshtml
2 years ago
c0bad938d7
feat: Split and restructure CLI logs
2 years ago
5adb966aa9
refactor: Add serilog to implicit usings
2 years ago
94b000c55f
build: Upgrade nuget packages for tests
2 years ago
adeb478777
fix: Exception when either Sonarr or Radarr configs are empty
2 years ago
7be4189378
refactor: Code cleanup
2 years ago
d66aa8ba44
refactor: Solution-wide code cleanup
2 years ago
86eca33eb3
refactor: Move Commands.Shared CS files up a level
...
This is to address a roslyn warning.
2 years ago
ce6afa4157
refactor: Fix more analysis issues
2 years ago
c226097cb5
refactor: Clone URL is now a Uri object
2 years ago
c45860d280
refactor: BaseUrl type is now Uri instead of string
2 years ago
7185cc5844
refactor: Fix various analysis issues
2 years ago
5d0db006ba
chore(style): Overhaul editorconfig
2 years ago
7bc5d407e3
build: Upgrade multiple nuget packages
2 years ago
4275336a8a
refactor: Fix unused member variable inspection issue
2 years ago
c05d73a84b
refactor: Remove redundant config validation
...
Validation already happens in ConfigParser, then SyncProcessor does not
need to do it as well.
2 years ago
8e22a5d561
test: Verify exceptional case for env var parsing
2 years ago
aa523a0e14
feat: Enable referencing environment variables in config
...
Closes #145
Closes #154
2 years ago
6e397aefcf
test: Restructure tests
2 years ago
b9dc15f6a7
refactor: Relocate secrets yaml behavior to secrets dir
2 years ago
6fb1d4ad66
feat: Improved preview output for release profiles
2 years ago
964aeb8380
feat: Improved preview output for custom formats
2 years ago
fd3d76bc55
refactor: Rename Empty/NotEmpty extension methods
2 years ago
61c9dbcbf9
feat: Improved preview output for quality sizes
2 years ago
806a0fa64f
refactor: Do not use "empty" for SonarrCommand terms
2 years ago
7cdd94e626
fix: Use right deprecation message based on arguments
2 years ago
de3bf08543
fix: Update local repo before running commands that need it
2 years ago
7a008a6639
feat: CLI Revamp
...
Deprecate old commands: create-config, radarr, sonarr
New commands: config, sync, list
2 years ago
3ed9d4c814
chore: Update run configurations in Rider
2 years ago
64306db2dc
refactor: Add exception message enricher
...
Allows exception message without a stack trace to be written to the
console, while full exception details are still written to file sinks.
2 years ago
d73a888247
fix: Do not print skipped CFs to the console
...
They are too verbose
2 years ago
8c7768891e
fix: Better handling of invalid CF cache entries
...
Due to changes in v4.1.1, sometimes invalid cache entries (zero-value)
were written to the cache. These are now treated as invalid and matches
by name will be performed.
Fixes #160
2 years ago
18edb84133
test: Use default for argument matcher
2 years ago
28fa09f328
fix: Set CF IDs when no cache entry is present
...
Fixes #160
2 years ago
7ad4654d85
fix: Remove unredacted request URI from log files on exception
2 years ago
fd216c1b60
fix: Service URL is now part of cache directory name
2 years ago
5c3da551bb
fix: Detect and warn about conflicting CFs during sync
2 years ago
350fd21358
refactor: Overhaul config validation logic
...
- Validation of custom formats in Sonarr v4 is now performed
2 years ago
6997f4ca6a
chore: Rider run configuration updates
2 years ago
d5cbdb8648
chore: Move test projects to a solution folder
2 years ago
fea6575ae8
style: Code cleanup on entire solution
2 years ago
3b44964479
feat: Add clear separation between instance logs in console output
2 years ago
a4be018c44
feat: More detail output for CF sync changes
2 years ago
0830d1d6c8
feat: Re-introduce the CF name field in cache for display purposes
...
The CF name in cache is needed when printing information about deleted
CFs to console output.
2 years ago
8023f7f011
fix: Use comments for group headers in custom format listing
2 years ago
7358521a7a
fix: Sort CFs alphabetically in CLI listing
2 years ago
3f393d9894
chore: Updates to Rider run configurations
2 years ago
d71bce4990
fix: Do not perform actual logic when doing preview
...
Fixes #158
2 years ago
f7a7902c2c
build: Update several package dependencies
2 years ago
08d1ced7b6
refactor: Newline after message, but before exception details
2 years ago
b3666ec3cb
refactor: Less verbose error messages
2 years ago
eb9898fdd7
refactor: Implement Yaml Behavior system for extending parsing features
...
YamlSerializerFactory continues to grow as we add parsing features to
YAML files. A new behavior system now provides granular sets of features
to the factory. To extend the functionality of the YAML parser,
implement the `IYamlBehavior` interface. It will automatically be
registered to Autofac and injected into `YamlSerializerFactory`.
2 years ago
fc0daf631b
refactor: Address analysis issues
2 years ago
77603b6c93
refactor: Rename all projects to have Recyclarr prefix
2 years ago
bbb2195df2
feat!: Change Sonarr quality definitions config YAML to match Radarr
...
- Shares same syntax as Radarr
- Only Sonarr impacted
- Default behavior of `preferred_ratio` changed.
- Hybrid quality definition removed.
2 years ago
ab352f6a4c
fix: Do not warn about empty configs when they aren't really empty
...
This was caused by a logic error that thought that a file was empty just
because it didn't find any configuration data relevant to the current
subcommand. For example, a config file that only has Radarr config in it
when you run `recyclarr sonarr`.
2 years ago
ebb33f3328
refactor: Log git error message on clone retry
2 years ago
8a124d12f9
fix: Allow empty YAML files to be loaded
...
- Better contextual logging for YAML files
- When there's a syntax error in file parsing, skip that file.
- When validation fails for instance config, skip just that instance.
- If a file is empty, print a warning and skip it.
- Print instance name (instead of URL) in more places.
2 years ago
51d0219a1a
refactor: Move RegisterMockFor to extension method
2 years ago
c981a555ad
test: Use log context for existing tests
2 years ago
9acdf7da14
feat: Improved logging
...
- Handle exceptions better (also write them to serilog)
- Better redaction code
- Less verbose HTTP exception output
- Log more details about git cmd failures
2 years ago
94e55b6182
build: Nuget package upgrades
2 years ago
c1eb21d9ba
build: Remove System.Private.Uri (no longer used)
...
This was only added to address vulnerability scan, but this package is
no longer implicitly referenced.
2 years ago
69aec1450a
build: Move ManagePackageVersionsCentrally to Build.props
2 years ago
8d091ff471
build: Upgrade GUI-specific nuget packages
2 years ago
2e31dacea9
refactor: Code changes after System.IO.Abstractions upgrade
2 years ago
e47e1b2f82
build: Upgrade System.IO.Abstractions
2 years ago
f16008d225
refactor: Use better argument handling for git operations
...
Use array of args instead of string concatenations. Simplifies the logic
and also makes quoting args easier / more portable.
2 years ago
2b28fb9c73
chore: Update Rider run configurations for .NET 7
2 years ago
360f683718
chore: Remove another riderMarkupCache.xml file
2 years ago
d04b10f9d0
refactor: Utilize DI for Flurl
...
The goal is to eliminate the need for a "global setup" step for HTTP
communication. This can instead be done in the composition root as part
of the factory to request FlurlClient objects.
2 years ago
2a79a50d50
fix: Address multiple issues with the config template
...
- Simplify the comment style for YAML intended to be uncommented by the
user. Now they just need to delete the leading hash and YAML will be
at the appropriate indentation.
- Add additional explanation at the top about how to set up
configuration based on the guide.
- Fix link to the configuration reference.
2 years ago
53d7233b1e
build: Remove LangVersion from build props
...
Prefer to use the language version that is enabled by default based on
compatibility with selected target framework.
2 years ago
4a9f753423
chore: Delete and ignore riderMarkupCache.xml
...
This file continuously changes which indicates to me it should not be
versioned. This file must be new because there's no documentation
regarding it.
2 years ago
dfce05a9e8
build: Update Rider project files
2 years ago
969499bf5a
build: Fix for test packages not being assigned to TestLibrary.csproj
2 years ago
e5a0302c13
chore: Delete global.json (not needed)
2 years ago
6811c2c816
refactor: Do not create the RepoDirectory on start up
...
Let the GitRepositoryFactory do it.
2 years ago
794c8733ef
test: Fix CompositionRoot tests
...
Some types do not get registered until later on after
CompositionRoot.Setup() is called. Use IntegrationFixture to fulfill
mock versions of those types.
2 years ago
d83edd9e2b
refactor: Add logging to GitRepository / Factory
2 years ago
46067dffb0
test: Do not use NotThrow() in composition root test
...
Because Fluent.Assertions does not print the full exception details when
you use `Should().NotThrow()`. See issue:
https://github.com/fluentassertions/fluentassertions/issues/2015
2 years ago
b34798eabb
feat!: Remove LibGit2Sharp Library
...
This library was causing numerous issues related to git operations. The
straw that broke the camel's back is that it does not do automatic
garbage collection (`git gc --auto`). So a user's repo directory
continues to grow in size.
The replacement is CliWrap, which is just a simple wrapper library that
allows easy execution of shell commands. Specifically, `git` commands.
BREAKING CHANGE: This change now requires the `git` executable to be
installed by the user if run on a host system. The git executable will
be provided automatically for the docker image.
2 years ago
f810749b32
chore: Shared run configs updated for .NET 7.0 paths
2 years ago
7fdca11bc4
revert: "chore: Move GitVersion.yml into src dir"
...
This reverts commit 724d2c41aa
2 years ago
9fc7444f3c
refactor: Fix ASP.NET warning
...
[ASP0012] Suggest using builder.Services instead of ConfigureServices
2 years ago
dd8b518735
build: Upgrade all Nuget packages
2 years ago
b5a692a710
build: Upgrade to .NET 7.0
2 years ago
1d604b141b
feat: Named instances support
...
Use mapping-style instead of array-style for instances in configuration
YAML.
2 years ago
4ae54d8f54
fix: Restore compare by name for CFs
...
This is still needed if there already exist CFs in Radarr/Sonarr with
the same name.
2 years ago
7bfecdb3f3
build: Add nuget.config
2 years ago
3df3bc869e
refactor: Silence unused Version param warning
2 years ago
2ed8bdb55e
chore: Jetbrains Rider .idea files
2 years ago
e4a3e9d1fe
refactor: Remove unused Resolve method in IntegrationFixture
...
This method also had a bug in it: It leaked the child lifetime scope.
2 years ago
56666a245a
refactor: Do not fail on missing DTO properties
...
Previously, if Sonarr or Radarr added a new property to a DTO, Recyclarr
would fail when attempting to deserialize those responses. The purpose
of this was to catch compatibility issues early. However, this actually
prohibits a more useful case: Deserializing only data we care about and
having the freedom to ignore other, superfluous stuff.
2 years ago
081856e19e
refactor: Generalize compatibility check logic
...
Previously, only Sonarr had compatibility checking logic, which also
consequently meant that version information was obtained and logged for
Sonarr services. However, Radarr had no such checks because
compatibility has not yet been an issue. However, we still would like to
see version information printed when running Radarr instances.
2 years ago
934f30d71e
refactor: Print Recyclarr version to debug logs
2 years ago
724d2c41aa
chore: Move GitVersion.yml into src dir
2 years ago
0dbc1ac7fd
feat: Support secrets in config ( #139 )
...
Fixes #105
2 years ago
e5750a97ba
refactor: Fix resharper analysis suggestions
2 years ago
a853f0830d
refactor: Separate config finding logic from ServiceCommand
...
Reason: Exception would be thrown when no config files are found when
invoking the various `--list` arguments. No configuration should not
prevent these from working.
2 years ago
f251bbeba4
feat: Support for loading configs in a directory
...
The `configs` directory may now be used to automatically load YAML
configuration files. Any YAML files in that directory are loaded without
using the `--config` option.
2 years ago
0b0fc1e7bc
refactor: Delete YamlDotNet ObjectFactory
...
This factory was incorrectly using an Autofac container to resolve
types. This led to symptoms like extra elements in arrays being
deserialized, due to those types being resolved by the DI container.
There's no real reason I can think of to depend on Autofac when
deserializing types from YAML. This object has been around since 1.0.0
and I do not remember why it was created.
2 years ago
835aae860b
refactor: Greatly simplify DI support code
...
- Get rid of `IServiceLocatorProxy`
- Get rid of `ICompositionRoot`
In addition, all unit tests avoid using `BaseCommand` directly, as it
does its own composition root setup and overrides the IntegrationFixture
test setup.
2 years ago
88bdc5a92e
refactor: Add JsonUtils class
2 years ago
dcfbccae2f
refactor: Use IServiceLocatorProxy instead of ILifetimeScope
...
In IntegrationFixture
2 years ago
cda317d3c3
fix: Run validation against Custom Formats in Sonarr
...
If custom formats are provided, run validation logic against them. This
also was an opportunity to make the ServiceConfiguration validation
logic reusable between Sonarr and Radarr.
2 years ago
e1e3afff02
refactor: Rename QualityProfileConfig ( #135 )
2 years ago
ada30da70b
build: Upgrade Microsoft.NET.Test.Sdk (patch)
2 years ago
035bb0e17a
build: Upgrade MudBlazor (patch)
2 years ago
ebc46abd75
build: Upgrade Serilog Packages (minor)
2 years ago
2e45fbe1c5
build: Upgrade FluentValidation (patch)
2 years ago
9470377856
build: Upgrade AutoMapper (major)
2 years ago
32d7aa8a67
build: Upgrade YamlDotNet
2 years ago
4ab18fc9b0
build: Upgrade System.IO.Abstractions
2 years ago
8c936951c0
chore: Update DotSettings file
2 years ago
c775bc3c4d
refactor: Address Resharper inspection issues
2 years ago
3d403ef737
feat!: Do not load config next to executable
...
BREAKING CHANGE: The deprecated feature that still allowed you to keep
your `recyclarr.yml` next to the executable has been removed. Your
`recyclarr.yml` configuration file must now be located in your
application data directory
2 years ago
71580acc40
refactor: Service cache test fixes & improved testability
2 years ago
63c3bff27a
feat!: Remove names support for custom formats
...
BREAKING CHANGE: The `names` property is no longer supported under
`custom_formats:`. This feature was previously deprecated.
2 years ago
bdaada1049
refactor: Remove unnecessary Reset and factory semantics from steps
2 years ago
87747680ba
refactor: Fix unit tests and change DI resolution a bit
...
The introduction of lifetime scopes inside of configuration processing
in the Command classes introduced issues with the way resolution
overrides happened especially with integration test fixtures.
2 years ago
735c8562fc
chore: Fix path to .editorconfig in Recyclarr.sln
2 years ago
a9e5875bc5
chore: Move .editorconfig up a level and make intent rules consistent
2 years ago
3a21465ff1
fix: Fix incorrect version enforcement for Sonarr
...
When using multiple instances of Sonarr at v4 and v3, it was possible to
get a VersionException due to stale information carrying over between
processing instances.
2 years ago
361078ef86
refactor: Use better error message for Sonarr v3/v4 enforcement
2 years ago
1619bd8817
fix: Show a warning for duplicate scores
2 years ago
a63d570ec5
refactor: Change Log property to field
2 years ago
5f418a9d90
refactor: Namespace inconsistency
2 years ago
2e189ff275
fix(sonarr): Run version enforcement always
...
Version enforcement was only running if the user specified release
profiles because that logic was unintentionally tightly coupled to them.
Now that logic runs regardless of whether the user is using RPs or CFs.
2 years ago
ba84b07713
fix: Use compact JSON in debug logs
...
When logging HTTP response/request bodies during communication with
Radarr, Sonarr, etc, use a compact form instead. The previous form had
newlines in it which ended up making the logs vertically very long and
hard to follow.
2 years ago
87843b4ee1
chore: Code cleanup
2 years ago
7a25f79fa8
feat: Custom format lists are now grouped by category
...
When using `--list-custom-formats` with either the `sonarr` or `radarr`
subcommand, custom formats will be grouped according to the respective
tables at the top of the "Collection of custom formats" page.
2 years ago
27b252f405
chore: Update DotSettings and editorconfig files
2 years ago
6ed7961c8c
build: Use Nuget central package management
...
Move all package versions from `Directory.Build.targets` to
`Directory.Packages.props` as shown here:
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#enabling-central-package-management
2 years ago
8acb3e17fc
refactor: Address several SonarCloud code smells
2 years ago
cafa181424
refactor: IGuideService abstracts where the CF data comes from
2 years ago
73fb40de04
refactor: Move CF config objects to ServiceConfiguration
2 years ago
77f15b7e79
refactor: Reorganize custom format code to support reuse with Sonarr
2 years ago
f6e6644af5
refactor: Throw error if using CFs in Sonarr v3
2 years ago
e686b300b1
refactor: Better name for service compat integration test
2 years ago
defb137a25
test: Make IntegrationFixture disposable
2 years ago
c5714f2bed
feat: Add setting to specify max log files to keep
...
A new `log_janitor` setting added to `settings.yml` to allow the user to
specify the maximum number of files to keep when doing log cleanup.
Additionally, the way startup tasks occur has been cleaned up /
refactored to make it easier to integration test.
2 years ago
af001250f1
test: Allow resolution of unregistered concrete types
2 years ago
f01edc5700
refactor: Change the design pattern for settings access
...
Simplify the factory pattern so that it creates settings more directly
instead of using a silly setter method.
Also implemented `IntegrationFixture` for easier integration testing.
2 years ago
1f70e7fb61
refactor: Use lifetime scope instead of single instance
...
This allows those types to be overridden in child lifetime scopes.
2 years ago
2db0faa00c
fix(sonarr): Error when using release profiles with Sonarr v4
...
Fixes #100
2 years ago
f87971fec1
refactor: Decouple release profiles from SonarrApi class
2 years ago
28aae58298
build: Upgrade FluentValidation to 11.2.1
2 years ago
28983c74f9
fix: CVE vulerabilite mitigation ( #113 )
...
Fixes #112
2 years ago
98e6b4ce59
fix(radarr): Remove all trash properties from guide CFs
...
Any property starting with `trash_` is now removed from guide CFs.
Fixes #109 .
2 years ago
37ad6fed55
feat(sonarr): New --list-qualities argument
...
For listing quality definition types in the guide.
2 years ago
e802c48e70
refactor(sonarr): Rename lister class
...
The new name better reflects its actual responsibility, which is to do
more than just print info about release profiles.
2 years ago
227e4e82e5
feat(radarr): New --list-qualities argument
...
For listing quality definition types in the guide.
2 years ago
0c835d0807
chore: Add Rider run configurations
2 years ago
fef596d5d4
refactor: Consolidate quality parser into guide service
2 years ago
07c4b48578
feat: Quality definition logic uses new JSON files
2 years ago
635e93b2db
refactor: Remove unused _fs fields
2 years ago
6400716150
refactor: Move Radarr & Sonarr code to Services directory
...
And update namespaces
2 years ago
1b9c407d97
build: Upgrade NSubstitute to v4.4.0
...
Fixes these issues that were introduced after v4.2.2:
- https://github.com/nsubstitute/NSubstitute/pull/683
- https://github.com/nsubstitute/NSubstitute/issues/685
- https://github.com/MRCollective/AutofacContrib.NSubstitute/issues/65
2 years ago
12915264dd
build: Stop using wildcard versions for nuget packages
...
In order to improve the stability and predictability of releases, I'm
favoring fixed version numbers over wildcards. This means upgrades will
be more tedious, but at least it will be easier to audit when things
break due to third party libraries.
2 years ago
1b6d42f719
refactor: Use metadata.json to find paths to CFs and RPs
2 years ago
9e3aab6e96
refactor(gui): Fix namespace for ReleaseProfileDataFilterTest
2 years ago
3b59c05d3e
build(gui): Upgrade Serilog.AspNetCore to v6.*
2 years ago
f7566030d9
build: Upgrade YamlDotNet to v12.*
2 years ago
8266410092
feat: New branch and sha1 repository settings
...
- `repository`: Branch name in the local clone to check out
- `sha1`: An explicit revision to reset to.
Fixes #27
2 years ago
1129f178a8
fix(sonarr): Validate and filter RPs after they're loaded
...
If there is invalid / empty data in the Trash Guide JSON data, filter
those out after they are loaded.
2 years ago
3a5e1f0c5e
refactor: Use IConsole instead of Console
2 years ago
8cbb9d0b46
fix: Do not dispose IConsole
2 years ago
fdd95a619f
fix: Log files did not have debug level logs
2 years ago
154ec7cf7e
feat: Deprecate `names` list for custom formats in config YAML
2 years ago
a2e287c244
feat: Introduce JSON schema into the config template
2 years ago
c0bc714739
chore: Disable warning CA1506 in Program.cs
2 years ago
5db22529ff
refactor: Custom format group table parser
2 years ago
ce1a61359d
build: Use wildcards for pkg versions in Gui project
2 years ago
b6e3552ffc
refactor: Add Serilog
2 years ago
Robert Dailey
Robert Dailey
voltron4lyfe
Robert Dailey
voltron4lyfe
snoopy82481